-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump deps for v0.7.0 release #127
Conversation
Even with the bump, Should it be built with a specific go version? |
@MichaelMure there were some changes to how we build releases that affect plugins. From the release notes highlights:
Since it looks like this library copy-paste's the example Makefile + script I recommend copy-pasting the latest.
Yes, it definitely needs to be built with a specific version of Go as an unfortunate reality of how plugins work in Go. That version is the one listed when you run Do you have any recommendations on how to better announce this (or future) changes that result in breakages to the plugin build process? |
I can confirm it loads correctly when built with -trimpath. |
It's the correct way IMHO, I just need to open my eyes (no promises). I updated the makefile and the localstack port (see https://github.com/localstack/localstack/releases/tag/v0.11.5, who doesn't like a breaking change in a patch version). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the build side, although idk much about localstack. Seems right though.
No description provided.